Skip to content

fix: account for scale attribute when limiting slimes #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathiascode merged 1 commit into from
Aug 9, 2025
Merged

fix: account for scale attribute when limiting slimes #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/pw/kaboom/extras/modules/entity/EntitySpawn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import org.bukkit.Chunk;
import org.bukkit.Material;
import org.bukkit.World;
import org.bukkit.attribute.Attribute;
import org.bukkit.attribute.AttributeInstance;
import org.bukkit.block.CreatureSpawner;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.AreaEffectCloud;
Expand Down Expand Up @@ -32,6 +34,7 @@
import com.destroystokyo.paper.event.entity.PreSpawnerSpawnEvent;
import org.bukkit.plugin.java.JavaPlugin;
import pw.kaboom.extras.Main;
import pw.kaboom.extras.util.Utility;

public final class EntitySpawn implements Listener {
private static final FileConfiguration CONFIG = JavaPlugin.getPlugin(Main.class).getConfig();
Expand Down Expand Up @@ -122,11 +125,12 @@ private void limitAreaEffectCloudRadius(final AreaEffectCloud cloud) {
}

private void limitSlimeSize(final Slime slime) {
if (slime.getSize() > 20) {
slime.setSize(20);
final AttributeInstance scaleInstance = slime.getAttribute(Attribute.SCALE);
final double scale = scaleInstance != null ? scaleInstance.getValue() : 1.0f;

} else if (slime.getSize() < -20) {
slime.setSize(-20);
if ((slime.getSize() * scale) > 20) {
slime.setSize(20);
Utility.resetAttribute(slime, Attribute.SCALE);
}
}

Expand Down