Comprehensive improvements: PHPDoc fixes, static analysis, CI updates, and trait organization #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… branch if on main
- Added isNotEmptyArray() to ArrayAssertions trait - Created comprehensive unit tests - Updated README.md with usage example - Complies with AGENTS.md requirements
…ng of assertion methods' - Changed @return self descriptions across all traits and main class - Based on PHPDoc consistency analysis from ArrayAssertions changes
- Unified @return descriptions to 'Enables fluent chaining of assertion methods' - Applied changes to all 8 traits for codebase uniformity
- Added runtime checks for empty prefix/suffix strings - Ensures PHPUnit assertions receive non-empty strings as expected - Maintains library flexibility while satisfying static analysis
- Changed startsWith and endsWith parameter types to non-empty-string - Ensures static analysis recognizes non-empty string requirements - Runtime checks already enforce this, now reflected in types
… strlen() and update PHPDoc for startsWith/endsWith params to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 45 new assertion methods across 8 traits, improves code organization, integrates PHPStan static analysis, updates CI for PHP 8.1-8.4, and enhances documentation.
Changes
Testing
Validation