Conversation
|
@jazzido, thanks for proposing this PR. This is definitely a feature worth adding. However, I don't think the PR is good to be merged the way it is at the moment. My main concern is, that I want the pdfListViewer to be "flexible, modular, easy to replace parts with other implementations". This is not really given with your implementation, as the spinner is hard coded ;) The way the textLayer and annotationLayer are integrated is already flexible to some extend. Maybe it's worth adding a bit of infrastructure to add support for spinners as well. Here is what I think:
@jazzido, do you see where I am heading? Let me know what you think. If you want I can do steps 1)-3) from above and then leave the stage for you to do 4)? |
That sounds about right. Adding an event library to Thanks! |
This is a proposed implementation of one of the features on the wishlist. Some notes:
positionstyle attribute of the.plv-page-container.page-containerdivsasrelative. That might cause problems when integratingpdfListViewon an already styled page. A possible alternative is to setposition: absoluteon the loading indicator and calculate its position withPageView.getCanvasPositionInViewer.Feel free to merge :)