fix(health): Flake check for detSys installed nix#478
Open
niksingh710 wants to merge 3 commits intomainfrom
Open
fix(health): Flake check for detSys installed nix#478niksingh710 wants to merge 3 commits intomainfrom
niksingh710 wants to merge 3 commits intomainfrom
Conversation
srid
reviewed
Aug 21, 2025
crates/nix_rs/src/info.rs
Outdated
Comment on lines
13
to
18
Member
There was a problem hiding this comment.
This is the right direction, but still doesn't quite capture the nix --version parsing as single action; this command is now being run twice now (as can be seen in your screenshot).
This is a big problem with using LLM to generate code. I'd suggest discarding it and rewriting from scratch as iterating further can be a waste of time.
So which type best captures the output of nix --version? Perhaps something like:
data NixVersion = NixVersion_Official VersionSpec | NixVersion_DetSys { detSysVersion :: VersionSpec, nixVersion :: VersionSpec
Member
There was a problem hiding this comment.
This is a big problem with using LLM to generate code.
A human can do better here. Types should be modelled based that which they are actually modelling, rather than to fit an existing implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #472 (based on the approach
2mentioned in #472)Better/Simpler Implementation of #473.
On MacOs virtual Machine
On Ubuntu virtual Machine (Simple Nix installation)