Open
Conversation
Author
|
Forgot this bit: I used ripgrep to see usage of the
|
junyu-w
reviewed
Oct 18, 2018
junyu-w
reviewed
Oct 18, 2018
Owner
|
@andres-lowrie thanks for the PR, I've reviewed and overall this looks solid! |
b24f486 to
0f9ed4b
Compare
Author
|
Finally got some down time (yay holidays!!) I believe I addressed the points you mentioned. I also rebased the branch for a cleaner commit message. Lmk if this needs anything else! Happy Holiday! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/DrakeW/corgi/issues/34
Offloads all terminal coloring to fatih/color
How I did testing: