Conversation
generating sources in tests was causing circular dependency problems, so we're back to generating sources in an xtask that is completely separate from the rest of the crate.
blinsay
force-pushed
the
push-wlmyyqzpzzmz
branch
from
23ae1f1 to
04c0b7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating sources in tests was causing a horrible circular dependency issue (see #3). Move codegen back to an xtask to avoid that.
I went with keeping the
xtaskas a member of the workspace so that it was easier to keepprost/tonicandprost-build/tonic-buildin sync between generation and the actual crate. There shouldn't be too much changed here - it's mostly moving the generation code to a new place and adding some package structure.The protoc version did change (from
27to29), but only because because Homebrew doesn't pinprotobuf@27but does pinprotobuf@29. I'll do a larger version bump in a separate PR.