Skip to content

[Utilities] fix bug converting MutableSparseMatrixCSC to SparseMatrixCSC #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Jan 29, 2026
+14 −3
Merged

[Utilities] fix bug converting MutableSparseMatrixCSC to SparseMatrixCSC #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Utilities/sparse_matrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,11 @@ _first_index(::Type{T}, ::ZeroBasedIndexing) where {T} = T(0)
_first_index(::Type{T}, ::OneBasedIndexing) where {T} = T(1)

_shift(x, ::T, ::T) where {T<:AbstractIndexing} = x
_shift(x::Integer, ::ZeroBasedIndexing, ::OneBasedIndexing) = x + 1
_shift(x::Integer, ::OneBasedIndexing, ::ZeroBasedIndexing) = x - 1
_shift(x::Array{<:Integer}, ::ZeroBasedIndexing, ::OneBasedIndexing) = x .+ 1
_shift(x::Integer, ::ZeroBasedIndexing, ::OneBasedIndexing) = x + one(typeof(x))
_shift(x::Integer, ::OneBasedIndexing, ::ZeroBasedIndexing) = x - one(typeof(x))
function _shift(x::Array{<:Integer}, ::ZeroBasedIndexing, ::OneBasedIndexing)
return x .+ one(eltype(x))
end

"""
mutable struct MutableSparseMatrixCSC{Tv,Ti<:Integer,I<:AbstractIndexing}
Expand Down
9 changes: 9 additions & 0 deletions test/Utilities/sparse_matrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ function test_ScalarAffine_OneBased()
return
end

function test_MutableSparseMatrixCSC_convert_to_Cint()
I = MOI.Utilities.ZeroBasedIndexing
A = MOI.Utilities.MutableSparseMatrixCSC{Float32,Int32,I}()
B = convert(SparseArrays.SparseMatrixCSC{Float32,Int32}, A)
@test B isa SparseArrays.SparseMatrixCSC{Float32,Int32}
@test isempty(B)
return
end

end

TestSparseMatrix.runtests()
Loading