Fix ConstraintDual transformation for SplitHyperRectangleBridge#2809
Merged
Fix ConstraintDual transformation for SplitHyperRectangleBridge#2809
Conversation
Member
|
I don't like that all the |
Member
|
It looks like this fixed some errors, but there are a couple of other issues |
Member
Author
|
I don't think it's an issue that this bridge is now used. If you want to go from Interval to Nonnegatives, it makes sense |
Member
Author
|
If you go |
Member
|
It makes sense that this bridge is chosen. It's just a large change (evidenced by the pretty broad failure of solver tests). But maybe that's okay. It's good if Hyperrectange gets more use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issues detected in the SolverTests run of #2808
I did not add any test since the test is in #2810
I did #2810 in a separate PR not only to show in CI that it would have caught this one but also to avoid delaying this PR and hence #2808 in case #2810 requires some discussion