Verify API Request Arguments in Tests #166
Conversation
- Refactored `SubmitQuery` in `pkg/app/api_client.go` to be a package-level variable for easier mocking. - Added `MockSubmitQuery` helper in `pkg/app/test_utils_mock.go`. - Updated `pkg/app/passage_test.go` to verify `Query.Verses` is populated correctly. - Updated `pkg/app/search_test.go` to verify `Query.Words` is populated correctly. - Updated `pkg/app/ask_test.go` to verify `Query.Prompt` and `Context.Verses` are populated correctly. - Verified that natural language routing logic is covered by existing and updated tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
julwrites
deleted the
update-natural-language-tests-16093589716565048798
branch
This change updates the test suite to rigorously verify that the application sends the correct API requests for different natural language inputs.
It refactors the
SubmitQueryfunction to be a mockable variable and introduces aMockSubmitQueryhelper. The tests for Passage, Search, and Ask handlers are then updated to inspect the outgoingQueryRequeststruct, ensuring that:Query.Verses.Query.Words.Query.Prompt(andContext.Versesif applicable).This addresses the user's requirement to confirm that the correct API fields are used for each interaction type and ensures comprehensive test coverage for these scenarios.
PR created automatically by Jules for task 16093589716565048798 started by @julwrites