Fix and verify parsing for Roman numeral and ordinal Bible book references #159
Conversation
Updated `pkg/app/bible_reference.go` to explicitly include keys for Roman numeral (e.g., "ii samuel", "i kings") and ordinal (e.g., "1st john") book names. This resolves an issue where greedy prefix matching incorrectly parsed inputs like "II Samuel" as "1 Samuel". Updated `pkg/app/natural_language_bible_test.go` to assert correct parsing for these cases and ensure tests pass reliably.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixed a parsing bug where Roman numeral book references (e.g., "II Samuel") were incorrectly identified due to greedy prefix matching. This was resolved by adding explicit keys for Roman numeral and ordinal book variations to the
BibleBooksmap inpkg/app/bible_reference.go. The exhaustive test suite inpkg/app/natural_language_bible_test.gowas also updated to verify correct behavior for these cases.PR created automatically by Jules for task 10195197260222108106 started by @julwrites