Functionality updates #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality of /lexicon is now covered by /search. Removed: - pkg/app/lexicon.go - pkg/app/lexicon_test.go - CMD_LEXICON constant and command handling - Reference in help message
Remove /lexicon command in favor of /search
- Introduce `CMD_PASSAGE` (/passage) for explicit passage retrieval. - Implement `ProcessNaturalLanguage` router for messages without commands. - Add `ExtractBibleReferences` in `pkg/app/bible_reference.go` to find multiple references in text. - Refactor `GetBibleAsk` to accept context verses. - Route short phrases to Search and longer prompts to Ask (with extracted references). - Add comprehensive integration tests in `pkg/app/natural_language_test.go` covering Passage, Search, and Ask scenarios.
…interface-tests
Updated `pkg/app/bible_reference.go` to explicitly include keys for Roman numeral (e.g., "ii samuel", "i kings") and ordinal (e.g., "1st john") book names. This resolves an issue where greedy prefix matching incorrectly parsed inputs like "II Samuel" as "1 Samuel". Updated `pkg/app/natural_language_bible_test.go` to assert correct parsing for these cases and ensure tests pass reliably.
… docs - Updated `CheckBibleReference` in `passage.go` to use `ParseBibleReference` instead of scraping. - Updated `IdentifyQuery` in `tms.go` to use `ParseBibleReference` for normalization. - Removed unused `projectID` parameter from `SubmitQuery` in `api_client.go` and updated all call sites. - Removed unused `secrets` imports. - Updated `README.md` and `HelpMessage` in `bot.go` to include `/search` and `/ask` commands.
…-update Refactor: Remove scraping validation and update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.