Skip to content

Refactor for BotPlatform update and Telegram class usage #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julwrites merged 1 commit into from
Nov 29, 2025
Merged

Refactor for BotPlatform update and Telegram class usage #153

julwrites merged 1 commit into from
Nov 29, 2025

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Nov 29, 2025

This PR refactors the ScriptureBot to align with the latest changes in BotPlatform (PR #17).

Key changes:

  1. Secrets Management: TELEGRAM_ADMIN_ID is now handled in SecretsData.
  2. Telegram Instantiation: The Telegram class is now instantiated with secrets (TELEGRAM_ID, TELEGRAM_ADMIN_ID) instead of relying on global state or env.Secrets.
  3. Bot Platform Integration:
    • Replaced static platform.PostFromProps calls with bot.Post(env) method calls.
    • Propagated the platform.Platform interface through ProcessCommand, RunCommands, HandleBotLogic, and GetDevo.
    • Removed env.Secrets usage (as it was removed from SessionData) and replaced it with direct calls to secrets.Get() for PROJECT_ID and ADMIN_ID.
  4. Testing: Added MockBot for unit testing the app logic without a real bot instance. Updated integration tests.

PR created automatically by Jules for task 5141351822751200936 started by @julwrites

@google-labs-jules
Refactor Telegram bot instantiation and secrets handling
6f74e32 
- Updated `pkg/secrets` to include `TELEGRAM_ADMIN_ID`.
- Updated `pkg/bot/telegram.go` to use the new `platform.Telegram` class and pass secrets on instantiation.
- Removed dependency on `BotPlatform/pkg/secrets` (removed in upstream).
- Refactored `pkg/app` and `pkg/bot` to pass `platform.Platform` interface instead of using static `platform.PostFromProps` (which was removed).
- Replaced direct `env.Secrets` usage in `pkg/app` with `secrets.Get()`.
- Added tests for `LoadSecrets` and updated existing tests to use `MockBot`.
- Updated `go.mod` to use the latest `BotPlatform` version.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Nov 29, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 29, 2025 02:02
@julwrites julwrites merged commit 894fa74 into staging Nov 29, 2025
1 check passed
@julwrites julwrites deleted the refactor-bot-platform-telegram branch December 7, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julwrites