Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses a formatting issue where Bible verses and headers were being merged into single blocks of text in the Telegram output.

Changes:

  1. Block Element Handling: The HTML parser in pkg/app/passage.go now explicitly identifies <p> and <h1>-<h4> tags as block elements. It wraps their content in newlines to ensure distinct paragraphs.
  2. Header Formatting: While headers are treated as blocks for layout purposes, they retain their inline formatting behavior (being wrapped in bold text).
  3. Refactoring: Consolidated the logic for block elements to avoid code duplication and ensure consistent behavior.

This fixes the issue where Verses 3-12 (which lacked internal <br> tags) were running together with headers and previous paragraphs.


PR created automatically by Jules for task 10353189328488629600 started by @julwrites

- Updated `pkg/app/passage.go` to treat `p` and `h1`-`h4` tags as block elements, wrapping them in newlines.
- Ensured headers are still formatted as bold text using `platform.TelegramBold`.
- Cleaned up redundant logic and confirmed functionality with a reproduction test (which was deleted after verification).
- This ensures proper visual separation of paragraphs and headers in the Telegram output, preventing run-on text.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 28, 2025 11:59
@julwrites julwrites merged commit a7039fb into staging Nov 28, 2025
1 check passed
@julwrites julwrites deleted the fix-passage-formatting branch November 28, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants