Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Refactored escapeMarkdownV2 in pkg/app/passage.go to strictly follow Telegram's MarkdownV2 escaping rules. The new implementation iterates over the string rune-by-rune and escapes all reserved characters (including \ and .). This prevents ambiguity and invalid payloads (like unescaped dots after escaped backslashes) that were causing API failures. Added robust unit tests for these scenarios.


PR created automatically by Jules for task 4764698470086750686 started by @julwrites

This change refactors `escapeMarkdownV2` to use a manual switch statement, ensuring that all reserved characters (including backslashes and dots) are explicitly and correctly escaped. This resolves issues where unescaped special characters, particularly in edge cases involving existing backslashes, caused `400 Bad Request` errors from the Telegram API.

- Replaced `strings.NewReplacer` with a rune-based loop.
- Added explicit test case for trailing dots and backslashes to prevent regression.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 28, 2025 07:56
@julwrites julwrites merged commit 35315ad into staging Nov 28, 2025
1 check passed
@julwrites julwrites deleted the fix-telegram-markdown-escaping branch November 28, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants