Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses the user's request to prevent duplicate pipeline runs and fixes a build error.

  1. CI/CD Optimization:

    • Removed push triggers from .github/workflows/automation.yml. It now runs only on pull_request events.
    • Updated .github/workflows/deployment.yml to run on push to the master branch. This ensures that deployment still occurs when code is merged, without relying on workflow_run (which depended on the now-removed master push trigger in automation).
  2. Build Fix:

    • Modified pkg/bot/sub.go to import the local pkg/secrets package.
    • Updated SubscriptionHandler to accept the local secrets.SecretsData struct and manually map it to the BotPlatform's secrets.SecretsData struct. This resolves the type mismatch error in main.go.
  3. Dockerfile Cleanup:

    • Capitalized as to AS in Dockerfile to silence lint warnings.

PR created automatically by Jules for task 10874757698276844763 started by @julwrites

- Remove 'push' trigger from automation.yml to prevent duplicate runs on PRs.
- Update deployment.yml to trigger on push to master, ensuring deployment on merge.
- Fix type mismatch in SubscriptionHandler by converting local secrets to platform secrets.
- Fix Dockerfile 'AS' casing warnings.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 28, 2025 05:46
@julwrites julwrites merged commit d6452b2 into staging Nov 28, 2025
1 check passed
@julwrites julwrites deleted the fix-cicd-and-build branch November 28, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants