Refactoring secret management across the whole repository #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the dependency on `secrets.yaml` and implements a new secret management strategy. - If `GCLOUD_PROJECT_ID` is set, secrets are fetched exclusively from Google Secret Manager. - If `GCLOUD_PROJECT_ID` is not set, secrets are fetched from environment variables for local development. This change also fixes the Firestore client initialization error by ensuring the `GCLOUD_PROJECT_ID` is correctly propagated to the datastore client. The `BotPlatform` dependency's `SecretsData` struct is now correctly populated to ensure compatibility.
Refactor Secret Management to Use Google Secret Manager
Authenticated Google Secret Manager client using `GCLOUD_SA_KEY` environment variable if present. Updated `setEnv` test utility to isolate tests from real Secret Manager by temporarily unsetting `GCLOUD_PROJECT_ID`.
Authenticate Secret Manager with GCLOUD_SA_KEY
Defensively unset env vars in all integration tests and fix API context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.