Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Updated pkg/secrets to support explicit authentication via GCLOUD_SA_KEY environment variable, enabling tests to run in authenticated environments. Also fixed test isolation in pkg/app to prevent accidental Secret Manager access during unit tests.


PR created automatically by Jules for task 15375844695840067266 started by @julwrites

Authenticated Google Secret Manager client using `GCLOUD_SA_KEY` environment variable if present.
Updated `setEnv` test utility to isolate tests from real Secret Manager by temporarily unsetting `GCLOUD_PROJECT_ID`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 28, 2025 02:04
@julwrites julwrites merged commit f207bf9 into staging Nov 28, 2025
1 check passed
@julwrites julwrites deleted the feature-gcloud-sa-auth branch November 28, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants