Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This change updates the Dockerfile and deployment.yml to correctly pass the GCLOUD_PROJECT_ID as an environment variable to the running container, which is required by the secrets package to fetch secrets from Google Secret Manager. The Dockerfile is modified to accept a build argument and set an environment variable, and the deployment workflow is updated to pass this argument.


PR created automatically by Jules for task 13419398203640231176 started by @julwrites

The `secrets` package expects the `GCLOUD_PROJECT_ID` to be available as an environment variable to fetch secrets from Google Secret Manager.

This change updates the `Dockerfile` to accept the `GCLOUD_PROJECT_ID` as a build argument and set it as an environment variable in the final container. The `deployment.yml` is also updated to pass this build argument during the Docker build process. This ensures that the `GCLOUD_PROJECT_ID` is available to the application at runtime.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites marked this pull request as ready for review November 26, 2025 03:56
@julwrites julwrites merged commit 8dce0e7 into staging Nov 26, 2025
1 check passed
@julwrites julwrites deleted the fix-gcloud-project-id-env-var branch November 26, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants