Refactoring secret management #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new centralized secrets management package that handles secrets from Google Secret Manager, .env files, and environment variables. The new `pkg/secrets` package provides a unified `Get` function that abstracts away the details of where secrets are stored. It prioritizes Google Secret Manager in production and CI environments, and falls back to .env files and environment variables for local development. The existing `api_client` and `database` packages have been refactored to use the new secrets handler. The test suite has been updated to ensure that all tests are properly isolated and that the new secrets management system is thoroughly tested.
This commit introduces a new centralized secrets management package that handles secrets from Google Secret Manager, .env files, and environment variables. The new `pkg/secrets` package provides a unified `Get` function that abstracts away the details of where secrets are stored. It prioritizes Google Secret Manager in production and CI environments, and falls back to .env files and environment variables for local development. The existing `api_client` and `database` packages have been refactored to use the new secrets handler. The test suite has been updated to ensure that all tests are properly isolated and that the new secrets management system is thoroughly tested.
Refactor/secrets management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.