Implement Fallback for Passage Retrieval #121
Conversation
Implements a fallback mechanism to use the deprecated passage retrieval logic if the Bible AI API call fails. - Modifies `GetBiblePassage` to catch errors from `SubmitQuery` and trigger the fallback. - Refactors `GetPassageHtml` to `GetPassageHTMLFunc` to allow for mocking in tests. - Updates all call-sites of `GetPassageHtml` to use the new `GetPassageHTMLFunc`. - Adds a new test case to `passage_test.go` to verify the fallback logic without making external network calls. - Fixes a pre-existing bug in `api_client.go` that was causing build failures.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change implements a fallback mechanism for bible passage retrieval. If the primary Bible AI API fails, the system will now revert to the deprecated logic of scraping the Bible Gateway website. The implementation includes a refactoring to allow for mocking in tests, ensuring that the new test case is self-contained and does not make any external network calls. Additionally, a pre-existing bug in the API client that was causing build failures has been fixed.
PR created automatically by Jules for task 11060293583069392053 started by @julwrites