Improve some memory access functionality#110
Merged
snideto merged 11 commits intojuergenH87:masterfrom Jan 29, 2026
Merged
Conversation
pull in filtering addition
drewr95
reviewed
Jan 27, 2026
drewr95
reviewed
Jan 27, 2026
drewr95
approved these changes
Jan 28, 2026
snideto
reviewed
Jan 29, 2026
snideto
approved these changes
Jan 29, 2026
snideto
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing this more I discovered a couple issues, one of the issues was that we weren't properly cleaning up state after a transaction was completed in the memory access class. This was causing some flakiness when trying to do multiple reads. Another thing I noticed was tangentially related to that, if we had an error occur in the transaction we didn't properly clean that up and there were times where we were subscribing the same callback multiple times, so I added a unique_subscribe method to the ecu to only subscribe if it isn't already subscribed. This helps us to make sure that we aren't subscribing methods multiple times without needing to check in multiple places.
I also expanded some coverage to have a test where we do multiple successful reads and writes
I suspect there are more underlying bugs, I'm currently investigating this more, will make a new pr if I find anything else