Preliminary support for ghc-9.14 #537
Draft
+1,106
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pBottomBy, and cropRightBy This change incorporates result cropping into the aforementioned cropping functions. Without that, the results were not getting extents etc. properly removed after cropping, resulting in that data being left in the rendering results and possibly causing application misbehavior when extents, cursor positions, etc. were reported erroneously.
…from RenderState This fixes a bug introduced in 696ae5c that cleared the visibility requests from the RenderState. While other state fields should indeed be cleared, this particular field is populated from EventM state prior to calling renderFinal. Without this, calls to makeVisible had no effect, completely breaking that approach to managing viewport scrolling.
erikd
force-pushed
the
erikd/ghc-9.14
branch
from
df0dd49 to
28cf121
Compare
Owner
|
Thank you! Do you know when 9.14 is due to be released? |
Contributor
Author
|
The final |
Owner
|
Okay. Thank you! |
Version 0.5 of microlens breaks the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using ghc-9.14.0.20250908.
Probably not worth merging this until after the first full release of ghc-9.14.