Conversation
Add persistent tracking of thumbnail fetch failures per video. Each 404 increments a counter; successful fetches reset it. Videos exceeding 10 failures are flagged bad and removed from active rotation. Adds thumbnail_issue_count column, httpStatus pass-through in fetch_url/fetch_thumbnail, and flagBrokenThumbnails cleanup in the sweep cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thumbnail_issue_countcolumn onaggro_videosfetch_url()andfetch_thumbnail()so callers can distinguish 404s from other failuresflagBrokenThumbnails()into the sweep aftercleanThumbs()Fixes AGGRO-1J
Post-deployment steps
After deploy, run the database migration on the production server:
This adds the
thumbnail_issue_countcolumn to the end ofaggro_videos. MySQL 8.0+ handles appended columns via instant DDL — no table copy, no locking.Verify the column exists:
No other manual steps are needed. Existing rows start at 0, and the counter begins incrementing on the next sweep cycle.
Test plan