Conversation
Add explicit $routes->cli() definitions for aggro/news, aggro/vimeo, aggro/youtube, and aggro/duration to prevent CLI access failures when HTTP methods are restricted (e.g., changing $routes->add() to $routes->get()). Changes: - Add 6 CLI route definitions to Routes.php - Create CliRouteRegressionTest to verify all crontab routes have corresponding $routes->cli() definitions - Create PhpVersionConsistencyTest to ensure PHP version matches across .crontab, deploy.yml, docksal.env, and composer.json - Create fin clicheck command to validate CLI routes at runtime - Add fin clicheck to test pipeline - Remove deprecated aggro/watch from crontab (no route exists)
- Check for CI4 404 page HTML pattern instead of matching "404" anywhere in output, which caused false failures when log content contained "404" - Add CLI routes for aggro/log and aggro/log-error - Show debug output when CLI route validation fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$routes->cli()definitions for all cron-accessible routes to prevent CLI access failures when HTTP methods are restrictedfin clicheckcommand to validate CLI routes at runtimeaggro/watchfrom crontabTest plan
fin testto verify all checks passfin clicheckvalidates all CLI routes