Fix compilation of docsgen, examples, and type tests#207
Open
ItsHarper wants to merge 1 commit intojscheiny:masterfrom
Open
Fix compilation of docsgen, examples, and type tests#207ItsHarper wants to merge 1 commit intojscheiny:masterfrom
docsgen, examples, and type tests#207ItsHarper wants to merge 1 commit intojscheiny:masterfrom
Conversation
`tsconfig.base.json` includes settings that apply to ALL typescript in the project (including tests and docsgen), while `tsconfig.src.base.json` includes settings that should only apply to the source code of the main library. This fixes the `include` and `exclude` fields intended for library compilation being applied to the `tests` and `docsgen` folders, which made those folders actually just compile the library instead of their actual code.
ItsHarper
force-pushed
the
chore/fix-verify
branch
from
e49d22e to
1b4d055
Compare
ItsHarper
changed the title
ItsHarper
changed the title
docsgen, examples, and type tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209
docsgen/tsconfig.json,docs/examples/tsconfig.jsonandtests/tsconfig.jsonall referencetsconfig.base.json, which specifiedincludeandexcludearrays that were intended for the primary project. As a result, those projects were actually building the library's code instead of their own (if you deletedist/docsgenand then runyarn verifyon the current main branch, it will fail becausedist/docsgencontains the wrong thing).This PR fixes this by extracting the
includeandexcludefields fromtsconfig.base.jsoninto a newtsconfig.src.base.jsonfile that is only referenced bytsconfig.cjs.jsonandtsconfig.esm.json.