Updates gtest source and comments out tests which breaks compilation.#17
Open
wanatpj wants to merge 2 commits intojscheiny:masterfrom
Open
Updates gtest source and comments out tests which breaks compilation.#17wanatpj wants to merge 2 commits intojscheiny:masterfrom
wanatpj wants to merge 2 commits intojscheiny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jscheiny
The library is not compiling, as gtest/gmock has changed a place from which it is served.
You can spot that I commented out a few tests. It is because they break compilation. I am planning to fix them in follow-up commits.
Feel free to give me some code review.