Conversation
|
jsardev
left a comment
jsardev
left a comment
There was a problem hiding this comment.
Thanks for your PR! A few comments 🙏
There was a problem hiding this comment.
issue: package-lock should not be in here as we use yarn
suggestion: directories like .idea should be in everyone's personal global configs, not in repositories as it's a personal preference, not something related to the codebase
| id={this.props.id} | ||
| className={this.props.className} | ||
| ref={e => (this.container = e)} | ||
| ref={e => { |
There was a problem hiding this comment.
suggestion: please leave the formatting as it was 🙏
|
Closing in favor of #270 |
2 participants
This PR tries to close #268.