Remove redundant non-null assertion operators.#198
Draft
12wrigja wants to merge 1 commit intojs-temporal:mainfrom
Draft
Remove redundant non-null assertion operators.#19812wrigja wants to merge 1 commit intojs-temporal:mainfrom
12wrigja wants to merge 1 commit intojs-temporal:mainfrom
Conversation
justingrant
reviewed
Dec 6, 2022
| static from(item: Params['from'][0]): Return['from'] { | ||
| return ES.ToTemporalCalendar(item); | ||
| } | ||
| [Symbol.toStringTag]!: 'Temporal.Calendar'; |
Contributor
There was a problem hiding this comment.
Does the reason we originally added this assertion (see #53 (comment)) not apply anymore? Does TS now emit [Symbol.toStringTag] even without the ! assertion?
Contributor
There was a problem hiding this comment.
Note that this is not actually a non-null assertion, it's a "definite assignment assertion" that means that this field will be initialized by non-constructor code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.