Catch up on proposal-temporal PRs#111
Merged
justingrant merged 3 commits intojs-temporal:mainfrom Dec 15, 2021
Merged
Conversation
ptomato
approved these changes
Dec 15, 2021
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I think the commit message about proposal-temporal PRs 1980 & 1976 should refer to 1980 & 1975 instead. Otherwise looks good, a correct port of the proposal-temporal PRs. I'm not 100% sure about some of the TypeScript stuff, maybe James would take a look at that.
justingrant
force-pushed
the
port-other-repo-prs
branch
from
ebcafa1 to
50837f8
Compare
Contributor
Author
Oops, fixed in latest force-push.
@12wrigja is out until after the new year and I need this PR to keep moving fwd on #109, so I'll plan to merge now and @12wrigja can take a peek when he gets back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits here to catch up with recent PRs over in proposal-temporal:
offsetstring inZonedDateTime-representing property bags tc39/proposal-temporal#1976zoneRequiredoption in ParseTemporalTimeZoneString & better align parsing to spec tc39/proposal-temporal#1979offsetstring inZonedDateTime-representing property bags tc39/proposal-temporal#1976 and Polyfill: remove unnecessary runtime assertions in PrepareTemporalFields and ToPartialRecord tc39/proposal-temporal#1980 (the latter was a subset of the lines covered by the former PR, so I just combined into one commit)