Open
Conversation
added 2 commits
November 9, 2017 16:31
- Renamed to pycrust10 - Created setup.py to make it available to install from pip install <path> - Added data_path parameter to CrustModel constructor. Allows to use external files.
- Added parameter `include_no_thickness` to to allow the inclusion of layers with thickness lower than 0.01 - Improved code.
jrleeman
requested changes
Nov 13, 2017
Owner
jrleeman
left a comment
jrleeman
left a comment
There was a problem hiding this comment.
Thanks for this! Curious - what are you using this for? As far as the package name. I'm thinking maybe crustmod or crust1 or similar. Thoughts?
Author
|
Hi! crust1 would be more descriptive I think. If you want, I can rename the package and make a commit |
Owner
|
Sure. I think we'll be good to merge then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install <path>