Add break_on_hyphens support for text with escape sequences #330
+142
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_split()override inSequenceTextWrapperto properly handlebreak_on_hyphenswhen text contains escape sequencesbreak_on_hyphensparameterProblem
When text had per-character escape sequences (e.g., each letter colored separately), the parent's
_split()regex couldn't correctly identify hyphens as break points because escape sequences were mixed into the text.Solution
The new
_split()method:_split()on stripped text to find break pointsFixes #329