Skip to content

Conversation

@syamjir
Copy link

@syamjir syamjir commented Nov 14, 2024

Hi @jovdim,

This pull request adds a simple paragraph formatting app with the following features:

All Capitalize: Converts all text to uppercase.
All Lowercase: Converts all text to lowercase.
First Letter Capitalize: Capitalizes the first letter of each word in the input text.
First Letter of Sentence Capitalization: Capitalizes the first letter of each sentence in the input text.
Copy to Clipboard: Allows users to copy the formatted text to the clipboard.
Reset: Resets the input and output fields.
This is a small app intended for contribution to the mini project collection.

Could you please review the app and provide feedback?

Thank you !

@jovdim
Copy link
Owner

jovdim commented Nov 15, 2024

Hi @syamjir ,

You’ve put together a really impressive mini app, and the detailed explanation in the PR is very thorough—nice job! 😊

To ensure everything aligns well with the project structure, could you take a look at the CONTRIBUTING.md file? (It looks like there’s a small detail missing—the image preview). It includes some guidelines and best practices that should help streamline your updates.

Once you've had a chance to review it and make any adjustments, feel free to reach out here. I’m looking forward to seeing this come together!

Copy link
Owner

@jovdim jovdim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, and everything else is spot on! 😊

One small thing— it seems like you missed adding a preview image for the mini app. Once that’s added, everything should be good to go!

Looking forward to seeing the final version!

@syamjir
Copy link
Author

syamjir commented Nov 15, 2024

Hi@jovdim, I have added the preview image. Please verify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants