IEX #175
Open
IEX #175
+144
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing fancy, but it works… the output doesn't match the other quotes either .. maybe a to do .. or not?
prove to travis that my other commit actually works…
curl, curl_escape, and readJSON need to have their package prefixed to satisfy travis
travis didn't like `try( getQuote.IEX( 'vxx' ) )`. Can't test this locally so just trying to `source` the definition of `getQuote.IEX` in there…
was sourcing from *tests* folder. no wonder travis didn't like it
just figuring out travis…
delete & replace for travis…
copied dirk's `sample.travis.yaml` so I can edit other parts of this and get it to pass
travis is still on trusty, so…
looks like josh got an old version from dirk https://docs.travis-ci.com/user/languages/r/
it was in
```structure(list(symbol = c("VXX", "SNAP"), price = c(12.785, 17.27),
size = c(100L, 200L), time = c(1498075199.954, 1498075184.411),
.Names = c("symbol", "price", "size", "time"),
row.names = 1:2, class = "data.frame")```, not the very sensible calls to `try`
accidentally deleted some of josh's tests
prefix with quantmod:: so travis finds these functions?
save time on travis build (why is it taking so long??)
should speed up builds … I used the wrong syntax before
found it…
there are hadleyverse dependencies in @jimhester and @craigcitro's `r` build @joshuaulrich doesn't want switching back for the PR
Owner
|
Please, just one pull request per feature. It's very hard for me to follow multiple pull requests that are similar. How is this different from #170? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this implements the changes we discussed correctly …
adds
getQuote.IEXfrom IEX's free/public TOPS feed and a fewbase::tests to verify bits of it