Skip to content

Conversation

@seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented May 15, 2021

PR Summary

This PR implements basic compatibility with jedi 18.0. The issue was that the default json serializer used by python json.dumps could not handle pathlib.Path objects. This PR addresses the issue by extending the default JSONEncoder class. pathlib.Path objects are converted to str before encoding them to json.

PR checklist

Please make sure that the following things have been addressed (and check the relevant checkboxes):

  • Commits respect our guidelines
  • Tests are passing properly (see here on how to run Elpy's tests)

Test are not really passing BUT the tests were not passing before this change anyway. At least some more tests are passing now.

@galaunay galaunay merged commit 8f81ad4 into jorgenschaefer:master Jun 30, 2021
@galaunay
Copy link
Collaborator

Duplicate of #1902.

#1895 will probably overwrite those modifications, but in the meantime, it will be nice to have jedi 0.18 working.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants