Skip to content

Ignore specific finalizeition errors to reduce noise for logs and users #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 2 commits into from
Jan 7, 2026
+20 −1
Merged

Ignore specific finalizeition errors to reduce noise for logs and users #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8263394
ignore specific finalizeition errors to reduce noice
SniperSister Jan 6, 2026
87aa3d7
cs fix
SniperSister Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Jobs/UpdateSite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public function handle(): void
// Run the postupdate steps
$postUpdateResult = $connection->finalizeUpdate(["fromVersion" => $healthResult->cms_version]);

if (!$postUpdateResult->success) {
if (!$postUpdateResult->success && !$postUpdateResult->hasIgnorableError()) {
throw new UpdateException(
"finalize",
"Update for site failed in postprocessing: " . $this->site->id . ", errors: " . json_encode($postUpdateResult->errors),
Expand Down
19 changes: 19 additions & 0 deletions app/RemoteSite/Responses/FinalizeUpdate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,23 @@ public function __construct(
public ?array $errors = null,
) {
}

public function hasIgnorableError(): bool
{
if (is_null($this->errors)) {
return false;
}

$errorString = (string) json_encode($this->errors);

if (str_contains($errorString, 'Undefined constant') && str_contains($errorString, 'T4PATH_MEDIA')) {
return true;
}

if (str_contains($errorString, 'Error on updating manifest cache') && str_contains($errorString, 'T4PATH_MEDIA')) {
return true;
}

return false;
}
}