#52 Arrow keys navigation and screen reader support for progress bar#106
Open
susyzan wants to merge 1 commit intojonof:masterfrom
Open
#52 Arrow keys navigation and screen reader support for progress bar#106susyzan wants to merge 1 commit intojonof:masterfrom
susyzan wants to merge 1 commit intojonof:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I created this pull request as a suggestion on how to implement keyboard support.
Users should be able to tab into the progress bar and the first cell, and use arrow keys to select the cell. Pressing tabs moves the focus out of the bar to the description.
What this code does:
IMPORTANT! I haven't implemented the tab arrow key navigation as it looks like it's taken care by Boost in aria.js updateTabFocus.
This is far from perfect and I could only test it on Chrome, Firefox, Safari on a Mac. I also briefly tested it with VoiceOver.
Unfortunately, it may be a bit rushed due to time limitations.
I hope this helps somehow.
Thanks
Susie