Adaptive simple threshold #34
Conversation
for now this just optinally makes the thresholds relative to the darkest non-zero pixel
jonnew
left a comment
jonnew
left a comment
There was a problem hiding this comment.
Needs some formatting and logic fixes before merge.
| //, | ||
| // ("mincomp,m", po::value<int>(), | ||
| // "Minimum compensation, optionally adjust thresholds by the darkest pixels in the region."), | ||
|
|
There was a problem hiding this comment.
Get rid of these comments. space between function defs should be one line.
| ("area,a", po::value<std::string>(), | ||
| "Array of floats, [min,max], specifying the minimum and maximum " | ||
| "object contour area in pixels^2.") | ||
|
|
There was a problem hiding this comment.
Get rid of white space around this option addition.
| if (oat::config::getNumericValue<int>(vm, config_table, "mincomp", mincomp, 0)) | ||
| set_mincomp_size(mincomp); | ||
|
|
||
|
|
|
|
||
| void SimpleThreshold::set_mincomp_size(int value) | ||
| { | ||
| std::cout << "mincomp set to " << value<<"\n"; |
| std::cout << "mincomp set to " << value<<"\n"; | ||
| if (value != 0) { | ||
| mincomp_on_ = true; | ||
|
|
| void set_max_object_area(double value) { max_object_area_ = value; } | ||
| void set_erode_size(int erode_px); | ||
| void set_dilate_size(int dilate_px); | ||
| void set_mincomp_size(int mincomp_val); |
There was a problem hiding this comment.
Don't need this member function. Those were only needed for the erode and dilate options because I had to set up a little smoothing kernel each time the value is changed.
| // Sizes of the erode and dilate blocks | ||
| int erode_px_ {0}, dilate_px_ {0}; | ||
| bool erode_on_ {false}, dilate_on_ {false}; | ||
| int erode_px_ {0}, dilate_px_ {0}, mincomp_val_ {0}; |
There was a problem hiding this comment.
int mincomp_ {0} on its own line with a an explanatory comment. It is not related to erode an dilate.
| int erode_px_ {0}, dilate_px_ {0}; | ||
| bool erode_on_ {false}, dilate_on_ {false}; | ||
| int erode_px_ {0}, dilate_px_ {0}, mincomp_val_ {0}; | ||
| bool erode_on_ {false}, dilate_on_ {false}, mincomp_on_ {false}; |
| nonmasked_frame_); | ||
|
|
||
| double mincomp_brightness =0; | ||
| if (mincomp_on_) |
There was a problem hiding this comment.
Get rid of mincomp_on variable and just do mincomp_ != 0 here.
Where is the value of mincomp_ being used? It looks like you are just always adding whatever the minimum of the non zero part of the frame to the threshold range.
In fact the if block should start before the first inRange call to get rid of the processing overhead if its not being used. It should end below the minMaxIdx function.
| if (mincomp_on_) | ||
| cv::minMaxIdx(frame, &mincomp_brightness,NULL,NULL,NULL,nonmasked_frame_); | ||
|
|
||
| //std::cout << " br " << mincomp_brightness <<"\n"; |
There was a problem hiding this comment.
Get rid of temporary std::out stuff.
2 participants
No description provided.