Fix duplicate keys #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you! So, my main concern here is actually that we'll end up producing fewer keys than expected, and so the results will no longer accurately match the expected mix 🤔 Unfortunately, we quickly run into the birthday problem here where the more keys you want, the more likely it is to hit duplicates when sampling randomly. I don't have a great solution for this... We could maybe generate sequential keys (not random) and then shuffle them instead (at least when the number of keys needed is large)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the issue #15
I have already shared my analysis and findings in this comment
Adding the
Ordrequirement seems logical but I understand that it is a breaking change.