-
Notifications
You must be signed in to change notification settings - Fork 0
Parameterize hardcoded file system paths for portability #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
4
commits into
master
Choose a base branch
from
copilot/parameterize-file-system-paths
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lution Co-authored-by: johnzfitch <10013448+johnzfitch@users.noreply.github.com>
Co-authored-by: johnzfitch <10013448+johnzfitch@users.noreply.github.com>
Co-authored-by: johnzfitch <10013448+johnzfitch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace hardcoded file system paths with dynamic configuration
Parameterize hardcoded file system paths for portability
Nov 15, 2025
johnzfitch
reviewed
Nov 16, 2025
Owner
johnzfitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
To use Codex here, create an environment for this repo. |
Owner
|
Summary
Testing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository contained hardcoded paths (
/home/zack/dev/iconics) throughout scripts and documentation, preventing use across different systems and users.Changes
Python Scripts
icon-manager.py: Addedget_icon_dir()to resolve paths fromICONICS_DIRenvironment variable or script locationimprove_metadata.py: Dynamic path resolution for batch processingShell Scripts
icon: Detects location via${BASH_SOURCE[0]}or$ICONICS_DIRcompletion.{bash,zsh}: Dynamic catalog discovery with fallbacksexamples/pre-commit-hook.sh: Usesiconcommand instead of absolute pathsDocumentation
~/iconicsas standard exampleICONICS_DIRusagePath Resolution
Priority order:
ICONICS_DIRenvironment variable~/iconicsfallback for completionsExample:
Files Changed: 12 files, +176/-46 lines
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.