Skip to content

Comments

Minor fix to download function#14

Open
standage wants to merge 2 commits intojohnsolk:masterfrom
standage:download
Open

Minor fix to download function#14
standage wants to merge 2 commits intojohnsolk:masterfrom
standage:download

Conversation

@standage
Copy link

  • no need to use Popen + wait; call or check_call will wait automatically
  • if you pass a string array rather than a string, you can leave shell=False which is better from a security perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant