Bugfix/nls fix translation installation, closes #565 #564 #556#566
Merged
joewing merged 2 commits intojoewing:masterfrom May 15, 2022
Merged
Bugfix/nls fix translation installation, closes #565 #564 #556#566joewing merged 2 commits intojoewing:masterfrom
joewing merged 2 commits intojoewing:masterfrom
Conversation
added 2 commits
May 15, 2022 09:48
This caused creation of po/*gmo files to stop so the last few were not completed.
This fixes installation where in po/Makefile @mkdir_p@ was not defined and caused po/*gmo translations installation failure
Author
|
@joewing you may also want to consider this - #432 (comment) Especially if you decide if this PR isn't warranted. |
Owner
|
Thanks! I don't see any reason not to merge these. |
Author
|
Thanks Joe 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 commits here that address some recent issues:
po/pt_BRin the comments at the top of the file closing pt_BR translation causes error in make #564AM_INIT_AUTOMAKEtoconfigure.acfixing a bug where@mkdir_p@was undefined inpo/Makefilecausing the failure of.mofiles to be installed addressing Translations not installing - automake (GNU automake) 1.16.2 #565 and Obsolete @mkdir_p@ macro in po/Makefile.in.in #556I tested this by trying to upgrade the autotools but that failed for me, so I researched a little and found that
AM_INIT_AUTOMAKEabsence may have been the cause. I duely tried that and this fix works withautomake-1.16.2andautomake-1.16.5, both withgettext-0.21.Thanks @joewing for your consideration of these commits.