Upgrade to Rails 7.2 and Ruby to 3.4 #928
Conversation
PatrickMcSweeny
force-pushed
the
rails-7.2
branch
3 times, most recently
from
40cab9d to
933daab
Compare
|
The two tests that are failing are the same ones I mentioned in this comment in the Rails 7.1 PR. |
|
|
||
| FEATURE_LENGTH = 1.week | ||
|
|
||
| enum search_status: { |
There was a problem hiding this comment.
I was getting warnings about keyword arguments for enums being deprecated in Rails 8.
There was a problem hiding this comment.
What's the formatting look like if you move each case to its own line? I wonder if that would drastically reduce this PR's diff.
There was a problem hiding this comment.
I tried that approach and it did reduce the diff.
| gem "webmock" | ||
| end | ||
|
|
||
| gem "abbrev" |
There was a problem hiding this comment.
CI wouldn't run without adding this gem
|
I confirmed manually that the image meta tag shows up successfully when on the developer page when an avatar is present. |
|
I did some digging into the error caused by the avatar object not persisting, and it looks like the validation is failing because the file fixture doesn't have values for byte_size or checksum. I was not able to figure out to add those values in a way that the validation would pass. |
PatrickMcSweeny
force-pushed
the
rails-7.2
branch
from
4864eed to
51cf9f4
Compare
PatrickMcSweeny
force-pushed
the
rails-7.2
branch
from
51cf9f4 to
4fce009
Compare
| gem "inline_svg" | ||
| gem "invisible_captcha" | ||
| gem "noticed" | ||
| gem "noticed", "~> 1.6.0" |
There was a problem hiding this comment.
Upgrading the noticed and pay gems to the latest versions would be a huge undertaking, so I think it makes more sense to pin them for now.
|
@joemasilotti Can you look at this soon? |
|
@joemasilotti What are your plans for this? |
2 participants
Pull request checklist
bin/check