This repository was archived by the owner on Dec 15, 2022. It is now read-only.
fix: remove snapshot view on controller dismissal #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timglorioso
changed the title
victorBaro
suggested changes
Jan 9, 2018
Contributor
victorBaro
left a comment
victorBaro
left a comment
There was a problem hiding this comment.
Take a look at my comments. Thank you very much for spotting this bug and submitting a PR.
| } | ||
|
|
||
| public override func viewWillDisappear(_ animated: Bool) { | ||
| super.viewWillDisappear(false) |
Contributor
Author
There was a problem hiding this comment.
Hm, I think I was just mimicking the approach for viewWillAppear(_:) without giving it too much thought 😅. Thinking we should just pass along the given animated value.
|
|
||
| if let imageView = view.subviews[0] as? UIImageView { | ||
| imageView.removeFromSuperview() | ||
| } |
Contributor
There was a problem hiding this comment.
Not a big fan of this casting and accessing the subviews array, it could change in the future. It might be better to keep a reference to the snapshot and remove it here.
Contributor
Author
There was a problem hiding this comment.
Agreed, I'll push an alternate solution soon.
Contributor
Author
|
Got around to cleaning this up, let me know what you think. |
zhynroman
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are identical to #8, just using a topic branch as per best practices. Fixes #5.
Worth noting you can witness #5 in action in the README gif when the slider values flash after card dismissal!
Thanks again for such an awesome package ❤️