Skip to content

Data model visualization #4739 #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ki10V01T wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Data model visualization #4739 #5004

Ki10V01T wants to merge 5 commits into from
+2,034 −2

Conversation

@Ki10V01T
Copy link
Contributor

@Ki10V01T Ki10V01T commented Dec 29, 2025

See: #4739

@Ki10V01T
Data model visualization task completed.
f1a4e07 
Unimplemented features:
1. Permissions for view
2. Download button
3. Mermaid
4. Separation by Data store
5. JavaDocs
6. Locales
@Ki10V01T
1. Download button has been removed
2984df4 
2. Locales creation is completed (need to check)
3. DataStore verification has been completed, no edits are required.
@Ki10V01T
1. Facets implementing has been started
20536ba 
2. Displaying system entities ability has been added
3. Is nullable, Is mandatory fields has been centered
4. Similar to Base64 algorithm encoding for PlantUML has been added
@Ki10V01T
1. UrlQueryParameter facet has been implemented with details for savi…
e1d7f61 
…ng filter filed input (need to discuss)

2. Search by like
3. RegExp support for search
4. Displaying intermediate tables for many-to-many relationships (LINKED_TABLE.LINKED_COLUMN)
5. Timeouts for ping diagram server
@Ki10V01T Ki10V01T self-assigned this Dec 29, 2025
@Ki10V01T
Copy link
Contributor Author

Ki10V01T commented Dec 29, 2025

Known issues:

  1. I had to implement details and hide the textField inside it to make the urlQueryParameter facet work correctly. This caused the markup to shift (this needs to be discussed).
  2. Flex-grow for the Is Nullable and Is Mandatory columns doesn't work. Because of this, they are slightly wider than necessary.

glebfox
glebfox requested changes Dec 30, 2025
View reviewed changes
jmix-translations/content/io/jmix/datatools/messages.properties

io.jmix.datatools.datamodel.app/EngineType=Engine type
io.jmix.datatools.datamodel.app/EngineType.MERMAID=Mermaid
io.jmix.datatools.datamodel.app/EngineType.PLANTUML=Plantuml
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's called PlantUML

jmix-translations/content/io/jmix/datatools/messages_ru.properties
io.jmix.datatools.datamodel.entity/AttributeModel=Модель атрибутов
io.jmix.datatools.datamodel.entity/AttributeModel.attributeName=Название атрибута
io.jmix.datatools.datamodel.entity/AttributeModel.columnName=Название колонки
io.jmix.datatools.datamodel.entity/AttributeModel.dbType=БД тип
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тип БД

jmix-translations/content/io/jmix/datatools/messages_ru.properties
io.jmix.datatools.datamodel.entity/AttributeModel.javaType=Java тип

io.jmix.datatools.datamodel.entity/EntityModel.attributes=Атрибуты
io.jmix.datatools.datamodel.entity/EntityModel.id=Идентификатор
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, ID doesn't require translation.

jmix-translations/content/io/jmix/datatools/messages_ru.properties
io.jmix.datatools.datamodel.entity/AttributeModel.dbType=БД тип
io.jmix.datatools.datamodel.entity/AttributeModel.id=Идентификатор
io.jmix.datatools.datamodel.entity/AttributeModel.isMandatory=Обязательный?
io.jmix.datatools.datamodel.entity/AttributeModel.isNullable=Нулевой?
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other options for translation?

jmix-datatools/datatools/src/main/java/io/jmix/datatools/datamodel/entity/package-info.java
* limitations under the License.
*/

@NonNullApi
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for entity package, because you can get/set nulls for any attribute.

...datatools-flowui/src/main/java/io/jmix/datatoolsflowui/view/datamodel/DataModelListView.java
}

dataModelManager.setFilteredModels(entityModelsDl.getContainer().getItems());
UI.getCurrent().getPage().open("datatl/data-diagram");
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add a comment, that you use UI.getCurrent().getPage().open intentionally to open a new browser tab.
  2. May need some delegate here so that a TabbedMode can open a new application tab instead.

...datatools-flowui/src/main/java/io/jmix/datatoolsflowui/view/datamodel/DataModelListView.java
try {
pattern = Pattern.compile(userInput, Pattern.CASE_INSENSITIVE);
} catch (PatternSyntaxException pse) {
entityNameFilter.setErrorMessage("Regular expression syntax is invalid");
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST be a localized message!

...datatools-flowui/src/main/java/io/jmix/datatoolsflowui/view/datamodel/DataModelListView.java

protected void applyLoadContextWithFiltering(List<String> findedEntityNames) {
if (findedEntityNames.isEmpty()) {
entityNameFilter.setErrorMessage("Entities not found");
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST be a localized message!

...ls-flowui/src/main/resources/io/jmix/datatoolsflowui/view/datamodel/data-model-list-view.xml
@@ -0,0 +1,75 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<view xmlns="http://jmix.io/schema/flowui/view"
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong:

Image

...ls-flowui/src/main/resources/io/jmix/datatoolsflowui/view/datamodel/data-model-list-view.xml
<layout alignItems="STRETCH"
expand="contentBox"
classNames="jmix-data-model-list-view-layout">
<hbox id="buttonsPanel" classNames="buttons-panel">
Copy link
Contributor

@glebfox glebfox Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I still think that the Search button is redundant.
Image
  1. <details> is unnecessary complication and breaks layout (see the screenshot above). A simple placeholder will do the trick + you have tooltip for detailed info.

@Ki10V01T
1. Details has been removed from View
2c98305 
2. Flex-grow has been fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glebfox glebfox glebfox requested changes

@knstvk knstvk Awaiting requested review from knstvk

@Gavrilov-Ivan Gavrilov-Ivan Awaiting requested review from Gavrilov-Ivan

Assignees

@Ki10V01T Ki10V01T

Labels

in: datatools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ki10V01T @glebfox