Fixes for install scripts #166
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JLTRY I have found a piece of code that exists for over 12 years that prevents the installation of the attachments extension if the folders of the component already exist.
I actually can't think of a reason to prevent this installation from proceeding if we are not deleting any data either from the database or from the file attachments folder. However I can think of a reason that we should not prompt the user to uninstall the extension. During uninstallation of the extension the /attachments folder that holds all attachment files is deleted that could result in data loss.
I will keep this PR in draft until I finish testing all install scripts to add any more fixes that are needed.