Open
Conversation
Open
Owner
|
Thanks for this! I'm also glad to discover this project found use for someone else (it was a subproject of nvencsharp for the CPU transcoding paths). I'll review this this weekend. |
Author
|
I also added the YuvConstants and the methods that use YuvConstants now |
Owner
|
@1fabi0 Mind updating the build instructions in the readme? I believe my patches were upstreamed. Also, I presume this is built off of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 I used you're code generator to update the LibYuv file. The test, that is implemented ran successful.
In the convert_argb.h there was quite a big part with stuff about YuvConstants which is defined in row.h I removed the part as marshaling Structs with tests seemed too much overhead right now.