Few fixes for ARM64 compilation on VS2019 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will aid consuming Win2D in projects such as this one: https://github.com/microsoft/Windows.UI.Composition-Win32-Samples/tree/master/dotnet/WinForms/AcrylicEffect
The method name in XAML is canvas_DrawAnimated but backend code is canvas_AnimatedDraw. This PR is to correct the backend code.
* Use latest installed Windows SDK version * Use VS2019 (v142) C++ toolchain * Use UniversalApiContract version in 18362 SDK * Fix build with VS2019 compiler * Fix Win2DValidatePlatformVersion when the version is 10.0 In later versions of Visual Studio, this means "the highest version out of whatever platform SDKs are installed". * Add VS2019 support to Win2D.proj * Use explicit SDK version * Use PlatformToolset from Win2D.Cpp.props * Update version in solution file header * Port ShaderCompiler fixes from xaml_islands branch * Re-add explicit PlatformToolset * Update code generator to match manual changes * Update README * Update build.cmd * Update TargetPlatformVersion in sample projects * Silence deprecation warning/error * Fix double-definition build error * Fix ambiguous-definition errors * Tests running on VS 2019.
azchohfi
force-pushed
the
add-arm64-support
branch
from
3faf62e to
da46d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.