Do not append "?" or "&" if no params. #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've spent an hour and a half trying to debug the following issue:
while trying to fetch some Wordpress content using `[{ $toxid->getCmsSnippet('section') }]` I was always getting a 301 response. I've found out that the CMS URL, from `http://sub.domain.com/`, was being changed to `http://sub.domain.com/?&` causing the CMS to return a 301 redirect response.
The proposed change should solve the issue by not appending any additional character if not needed.
I've not fully tested it, it does work with my situation.
Owner
|
Sorry, i've missed that one and merged another one doing the same but with not such a nice code. I will close this one, but would be happy if you redo that good work. Sorry for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: #47.
I've spent an hour and a half trying to debug the following issue:
while trying to fetch some Wordpress content using
[{ $toxid->getCmsSnippet('section') }]I was always getting a 301 response. I've found out that the CMS URL, fromhttp://sub.domain.com/, was being changed tohttp://sub.domain.com/?&causing the CMS to return a 301 redirect response.The proposed change should solve the issue by not appending any additional character if not needed.
I've not fully tested it, it does work in my situation.