This repository was archived by the owner on Jun 8, 2019. It is now read-only.
Optional ConditionMethod arguments, ignoreCase argument for standard condition methods, EventLogTarget enhancements#12
Open
tg73 wants to merge 8 commits intojkowalski:masterfrom
zanyants:master
Open
Optional ConditionMethod arguments, ignoreCase argument for standard condition methods, EventLogTarget enhancements#12tg73 wants to merge 8 commits intojkowalski:masterfrom zanyants:master
tg73 wants to merge 8 commits intojkowalski:masterfrom
zanyants:master
Conversation
- header and footer, with optional newlines - batched writes (eg, via Buffering wrapper), with optional per-LogLevel grouping - two overflow handling modes - truncate (what it always used to do) and split (currently a simplistic implementation)
…rameters can be omitted from the end of the parameter list (only).
…, retaining original behaviour as the default. Added new strequals function for string comparison with optional ignoreCase argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jaroslaw,
As a general note, I couldn't find any "how to contribute" documentation, so I'm not sure how you handle contributions, notably regarding copyright. For now, I've added copyright entries in the files I've touched/created with my name, but I'm open to discussion on this.
I've built the code via build.cmd for netfx40, netfx35, netfx20 and sl3 (that's all the SDKs I've got installed) and addressed any code analysis issues. I've tested under netfx40 (including my silverlight-only code). I've also verified that the generated XSD appears to be correct for the EventLogTarget changes, and syncronized projects.
Regards,
Tom