Skip to content

Stop using use vars #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guillemj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stop using use vars #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b874e
Import Exporter's import instead of setting @ISA
guillemj Jul 13, 2017
74d4515
Switch from «use vars» to «our»
guillemj Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/File/Path.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,12 @@ BEGIN {
}
}

use Exporter ();
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);
$VERSION = '2.17';
$VERSION = eval $VERSION;
@ISA = qw(Exporter);
@EXPORT = qw(mkpath rmtree);
@EXPORT_OK = qw(make_path remove_tree);
use Exporter qw(import);

our $VERSION = '2.17';
$VERSION = eval $VERSION;
our @EXPORT = qw(mkpath rmtree);
our @EXPORT_OK = qw(make_path remove_tree);

BEGIN {
for (qw(VMS MacOS MSWin32 os2)) {
Expand Down